Skip to content

KatVr #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

KatVr #133

wants to merge 3 commits into from

Conversation

Alex-redman
Copy link

@Alex-redman Alex-redman commented Oct 26, 2024 •
edited
Loading

@TarasHoliuk
Copy link

  1. Favicon looks too small. It would be nice to set a bigger one:

image

  1. These icon links should open in the new tab (because it's external links):

image

  1. Design:

image

The "Help" modal looks differently in the App in desktop version:

image

Also, there is no modal for "FAQ" button at all

  1. There should be a few forms (a few stages) that appear when the user clicks "Buy" button:

image

  1. On the mobile version it would be nice to center the image (and/or probably make it bigger) for different screen sizes, not only on hardcoded 320px width:

image
image

  1. The dropdown and + buttons should work:

image

  1. The video modal should appear when the user clicks on "Video" button:

image
https://www.w3schools.com/html/html_youtube.asp

TarasHoliuk
TarasHoliuk suggested changes Oct 27, 2024
View reviewed changes
Copy link

@TarasHoliuk TarasHoliuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! You did a great job!

But there are some parts of the landing page that aren't implemented yet. For sure this landing page is one of the most difficult. So feel free to ask for help in the chat/join Q&A session. Some features are way easier to implement with some JS knowledges. So if you cannot implement something yet add a comment about that so a mentor won't reject the task because of it. And when you learn JS you will finish these features 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarasHoliuk TarasHoliuk TarasHoliuk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alex-redman @TarasHoliuk